Fix for zones reopening in simulation-based constraint mechanism for work/school location choice#1028
Merged
jpn-- merged 5 commits intoActivitySim:mainfrom Jan 15, 2026
Merged
Conversation
jpn--
approved these changes
Jan 8, 2026
Member
jpn--
left a comment
jpn--
left a comment
There was a problem hiding this comment.
This is great! Here's why I like it:
- You have written a clear and simple test that creates a tiny model, runs it, and fails on the existing code in a manner that clearly demonstrates the existing problem and runs in under one second.
- After the code changes are made, the test passes. Voila!
The one thing that's missing is a note on the change log activitysim/docs/dev-guide/changes.md. This is not really what may of us would call a "breaking change" as it should not formally cause any existing model to fail, but it does break strict reproducibility between versions. This is seen in the SANDAG test, which now fails because the shadow-priced location choices are changing just a tiny bit.
Contributor
Author
|
Great! Glad you like the test -- it was not a trivial exercise to get a nice CI test built for this particular issue. And we also now have a CI test for the simulation-based constraint mechanism as a whole as a bonus! I have updated the change log. I think this is ready to merge! |
jpn--
approved these changes
Jan 15, 2026
dhensle
added a commit
to RSGInc/activitysim
that referenced
this pull request
Mar 4, 2026
commit c031c8b Author: David Hensle <hensle93@gmail.com> Date: Fri Feb 13 15:48:35 2026 -0800 adding ignore list to skim load for unused skims commit 83613b2 Author: Copilot <198982749+Copilot@users.noreply.github.com> Date: Thu Feb 12 16:30:58 2026 -0600 Fix Sphinx currentmodule directive for location choice documentation (ActivitySim#1034) * Initial plan * Fix currentmodule directive in work_location_choice.md and school_location_choice.md Co-authored-by: jpn-- <1036626+jpn--@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: jpn-- <1036626+jpn--@users.noreply.github.com> commit aa58cc4 Author: David Hensle <51132108+dhensle@users.noreply.github.com> Date: Fri Jan 16 03:31:07 2026 +1100 Fix for zones reopening in simulation-based constraint mechanism for work/school location choice (ActivitySim#1028) * addresses issue with zones reopening after being closed in shadow_pricing * addresses issue with zones reopening after being closed in shadow_pricing * adding shadow price regression values * updating change log --------- Co-authored-by: juangacosta <juan.acosta@rsginc.com> commit 6266ce4 Author: David Hensle <51132108+dhensle@users.noreply.github.com> Date: Thu Jan 8 10:26:48 2026 -0800 Index names consistently set to "alt" for alternatives files (ActivitySim#1018) * "alt" now used as index in all alternatives modules * formatting * minor commenting * using stable sorting for unit test * adding to change log * updating school escort bundle Alt to alt * typo * Revert "updating school escort bundle Alt to alt" This reverts commit 625f685. * regenerate pipeline --------- Co-authored-by: juangacosta <juan.acosta@rsginc.com> Co-authored-by: Jeffrey Newman <jeff@driftless.xyz> commit 0811191 Author: Jeffrey Newman <jeff@driftless.xyz> Date: Thu Jan 8 11:11:43 2026 -0600 Repair CDAP estimation (ActivitySim#1026) * fix error in CDAP estimation model construction * update tests for CDAP * fix the other test file * add to changes.md * note on possible fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #820: If zones close, they now remain closed.